From 37c96e8e237da8835206f4911ef6c51c1931c1e6 Mon Sep 17 00:00:00 2001
From: Chris Coley <chris@codingallnight.com>
Date: Sun, 23 Apr 2023 03:15:22 -0700
Subject: [PATCH] Fix the review CI job

---
 .gitlab-ci.yml | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 847812d..877a0e3 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -14,23 +14,22 @@ workflow:
   stage: deploy
   tags:
     - docker
-  rules:
-    - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
-      when: never
   script:
     - sed -i "s/%%BRANCH%%/$CI_COMMIT_BRANCH/g" src/index.html
     - mv src public
   artifacts:
     paths:
       - public/
-  environment:
-    name: review/$CI_COMMIT_BRANCH
-    url: "https://$CI_PROJECT_NAMESPACE.$CI_PAGES_DOMAIN/-/$CI_PROJECT_NAME/-/jobs/$CI_JOB_ID/artifacts/public/index.html"
 
 # Deploy a review environment for any push to a branch that is not the default
 # branch
 review:
   extends: .deploy
+  rules:
+    - if: $CI_COMMIT_BRANCH != $CI_DEFAULT_BRANCH
+  environment:
+    name: review/$CI_COMMIT_BRANCH
+    url: "https://$CI_PROJECT_NAMESPACE.$CI_PAGES_DOMAIN/-/$CI_PROJECT_NAME/-/jobs/$CI_JOB_ID/artifacts/public/index.html"
 
 # Deploy to GitLab Pages for pushes on the default branch
 pages:
-- 
GitLab